Go Back   NinjaTrader Support Forum > Suggestions and Feedback > Suggestions And Feedback

Suggestions And Feedback New feature suggestions and feedback.

Reply
 
Thread Tools Display Modes
Old 01-23-2010, 09:45 PM   #1
David Lean
Senior Member
 
Join Date: Oct 2009
Location: Australia
Posts: 108
Thanks: 2
Thanked 19 times in 8 posts
Unhappy BUG: PriorDayOHLC, doesn't work on Mondays.

Summary
The PriorDayOHLC values are always zero on a monday. This is because it is using Sundays data for its calculation & there is no data.
NB: It may be possible that this indicator works correctly in USA for USA markets as they have no data on Saturday. If so, test this by setting your system clock to a different timemzone. (try really east like Australia or New Zealand)

Detail
There is an implicit assumption in many of Ninja indicators that the market is open 7 * 24 hrs. I've noticed that this creates many bugs where :-
i) the market closes over the weekend. or
ii) the market closes for more than 15 mins. ie Euro Stoxx or
iii) the market Opens & Closes on different calendar dates. (very common when your local timezone is not USA.

In this case PriorDayOHLC is looking at Calendar Days not Trading days. (Actually it is looking at the undocumented "CurrrentDate" but the effect is the same.)

As Friday's EuroStoxx session closes at Sat 8:15am (AEDT) & Opens Monday 6pm (AEDT). This causes the PriorDayOHLC prices to all become PriorClose.
Making this indicator useless on a Monday & very dangerous to use in any of your own indicators.

Workaround
I keep a IntSeries called SessionCount which starts at 1, it holds the same value for all candles until Bars.FirstBarOfSession = true. When I increment the SessionCount by one.

This lets me use the index of any two bars to see if they are also in the same trading session. It also avoids counting non-trading days like Public Holidays & weekends.

I hope this helps
Dave
Last edited by David Lean; 01-23-2010 at 09:51 PM.
David Lean is offline  
Reply With Quote
Old 01-24-2010, 11:57 AM   #2
NinjaTrader_Ben
NinjaTrader Customer Service
 
NinjaTrader_Ben's Avatar
 
Join Date: May 2008
Location: Denver, CO
Posts: 3,157
Thanks: 0
Thanked 4 times in 4 posts
Default

Hello,

I will send your suggestion to our development team for consideration, thanks!
NinjaTrader_Ben is offline  
Reply With Quote
Old 01-25-2010, 05:25 AM   #3
Mindset
Senior Member
 
Join Date: Mar 2008
Location: UK West Sussex
Posts: 693
Thanks: 18
Thanked 19 times in 14 posts
Default Prior OHLC

David

I see where you are coming from but my experience on the Dax/EuroStoxx futures is that it works fine on a Monday?(In 7beta6)
Maybe they fixed it?
Mindset is offline  
Reply With Quote
Reply

Tags
bug, priordayohlc

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
PriorDayOHLC Problem PrTester Indicator Development 14 08-05-2011 03:43 AM
Bug Crosshair cursor does not work on negative values MicroAl Version 7 Beta General Questions & Bug Reports 3 11-15-2009 03:36 AM
PriorDayOHLC stefy Strategy Development 1 02-06-2009 01:02 PM
Bug: Nymex Crude contract doesn't work with Patsystems shawnj Connecting 1 07-04-2008 08:29 AM
Editor Bug - Intellisence doesn't work properly with Generics Collections shawnj General Programming 2 05-26-2008 10:16 PM


All times are GMT -6. The time now is 11:04 PM.

FULL RISK DISCLOSURE: Futures trading contains substantial risk and is not for every investor. An investor could potentially lose all or more than the initial investment. Risk capital is money that can be lost without jeopardizing ones financial security or lifestyle. Only risk capital should be used for trading and only those with sufficient risk capital should consider trading. Past performance is not necessarily indicative of future results. View Full Risk Disclosure.