Tushar Chande's Trendscore

[Elliott Wave]

I was watching a trading lecture that mentioned this indicator and it seemed interesting.

The code is so hopelessly simple that I'm embarrassed I've spent the last hour and still can't get it to plot. I'm obviously overlooking something very basic and was hoping someone could take a look at it.

This is the Metastock code and I've attached the MetaTrader indicator (which I tried to convert)

Chande's Trendscore                                                    If(C>=Ref(C,-11),1,-1) + If(C>=Ref(C,-12),1,-1) + 
  If(C>=Ref(C,-13),1,-1) + If(C>=Ref(C,-14),1,-1) + 
  If(C>=Ref(C,-15),1,-1) + If(C>=Ref(C,-16),1,-1) +
  If(C>=Ref(C,-17),1,-1) + If(C>=Ref(C,-18),1,-1) + 
  If(C>=Ref(C,-19),1,-1) + If(C>=Ref(C,-20),1,-1)

In MetaTrader it seems the 'meat' of it is;

for (score=0,k=0; k<LookBackLength; k++)
                  if (Close[i] >= Close[i+k+LookBack])
                        score++;
                  else  score--;                        
         TrendBuffer[i] = score/LookBackLength;

Which would be something like this in NT;

for (score=0,k=0; k<LookBackLength; k++)
                  if (Close[0] >= Close[k+LookBack])
                        score++;
                  else  score--;                        
         TrendBuffer.Set(score/LookBackLength);

thanks in advance.

[mrlogik]

Hey Elliott

What are you getting on your plot? (I cant try the code until later today)

Also, I suggest you always use brackets around statements just to keep things clean and 100% certain the logic is executing as you suspect. Additionally, keep the for statement to only "controlled" variables (so here we remove the score). This is probably not the cause of a problem, but it makes code more readable.

score = 0;
for(int k = 0 ; k < LookBackLength ; k++)
{
  if(Close[0] >= Close[k + LookBack])
     score++;
  else
     score--;
}

let me know

[rt6176]

Elliot,

I'm curious about this code,

you posted :
------------------------------------------------------------------
for (score=0,k=0; k<LookBackLength; k++)
if (Close[0] >= Close[k+LookBack])
score++;
else score--;
TrendBuffer.Set(score/LookBackLength);
-----------------------------------------------------------------

OK, my stupid question first. Is this an issue?

if CurrentBar < (k+LookBack)
return;

-----------------------------------------------------------------

Anyway, could you show us the NT code you developed so far...

Thanks,

RJay

[mrlogik]

If what rt is suggesting is the problem you should see an error in the LOG tab.

[Elliott Wave]

I'll take another look today after being well rested, but I tried many different things included busting out my C# for dummies and changing the for loop to a while loop etc.

I think part of the issue is that the MT4 indicator is multi-timeframe and has some code I don't think is needed, but perhaps is.

I also tried doing a very inefficient string of 20 if/else statements regarding Close[0] > Close [1, 2, 3] etc, and no matter what I couldn't get anything to plot.

[roonius]

Is this what are you looking for?
I hope I understood the logics properly...
Looks like rt6176 was right

[Elliott Wave]

That looks exactly right, I'll check it out now and try to learn where I was going wrong.

While I feel I'm improving at NinjaScript sometimes the only way to see where I was going wrong is to see it right.

[Elliott Wave]

It seems to work perfect.

I added a description and interpretation instructions as well as a zero line and fixed the parameter spellings (length vs lenght).

Very simple code, but it seems quite effective for what its supposed to do.

[roonius]

Thanks,

Since English is not my native, I appologize in advance for future spelling mistakes.

[Elliott Wave]

Since C# is not my native language I apologize in advance for any future bonehead coding mistakes. lol

Its good to have you here Roonuis and thanks again for contributing.

[smalltrader35]

Can anybody re-write this Indicator for NT7?