B21 upgrade - All custom indicators gone

[mpe66]

I followed the required steps for upgrading. Now all my custom indicators are gone and I can't try importing them again because there are ninja script errors (which weren't there before upgrading). Is this related to new ninja script methods in b21? Is there an easy fix?

Mpe

[NinjaTrader_Bertrand]

Mpe, can you please first of all ensure you can compile all script as presently installed right now?

NinjaScript method wise those changes below were introduced with B21 release -

 
4054
NinjaScript indicators
@PriorDayOHLC/@CurrentDayOHL uses new NinjaScript method 'GetTradingDayFromLocal()' instead of 'GetSessionDate()' which is not public anymore.
 
4055
NinjaScript
GetSessionBar() was not working as expected on some session templates and is now deprecated. Please use new GetDayBar() method instead.

[mpe66]

Originally Posted by NinjaTrader_Bertrand

Mpe, can you please first of all ensure you can compile all script as presently installed right now?

NinjaScript method wise those changes below were introduced with B21 release -

 
4054
NinjaScript indicators
@PriorDayOHLC/@CurrentDayOHL uses new NinjaScript method 'GetTradingDayFromLocal()' instead of 'GetSessionDate()' which is not public anymore.
 
4055
NinjaScript
GetSessionBar() was not working as expected on some session templates and is now deprecated. Please use new GetDayBar() method instead.

Ok, I removed imarketprofile7_b and now my indicators compile and work again. But now I get another problem. The same problem as mjc4118 reported here. I have a custom indicator, vwap oscillator that uses the VWAP indicator. My oscillator is plotted correctly in its own panel, but now the VWAP indicator is overlayed on the price panel for some reason.

Mpe

[NinjaTrader_Bertrand]

Mpe, ok good to hear - are you setting the ScaleJustification from any of those indicator programmatically? Any way I could give those are run here on my B21 to check into?

Thanks

[mpe66]

Ok I've attached the scripts. You need to use cvax version of VWAP for it to work. I noticed another problem too. When I try saving my workspace I get a message that nt needs to shut down, email support etc. This doesn't happen when saving a workspace that doesn't contain any of my custom indicators.

[NinjaTrader_Bertrand]

Thanks - will test them and get back to you.

[richbois]

When I installed V21 I had problems with the 2 files that are mentioned here

@CurrentDayOHLC and @PriorDayOHLC

I deleted them and all my other scripts compiled fine and all is well now

I then used the old version of these 2 from the back up I had made just before the update.

They also compiled fine

I didnt try to use them

Is this the best solution or is there a better one???????????

Thanks

[YanCanCook]

I have this exact problem with my custom indicator. It worked on b20. now it overlays on top of the price chart and hides everything. Needless to say, I was not able to find any workaround and ended up removing my custom indicator.

[farshadro]

I found the problem in my case to be "Imarketprofile version 6.5 and 7" custom indicator. I deleted that and everything else is working.

[NinjaTrader_Bertrand]

Guys, thanks all for reporting in : unfortunately we identified a bug in this area which will be fixed with B22 - please retest your scenrios then.

Thanks for the support in this process

[mmtrader]

Support,

Has this problem been fixed in Beta 22? I understand Beta 21 has some code breaking changes in it which impacts custom indicators,so still using beta 20.

Any simpler way to upgrade to beta 22 or 23 when released,so that previous indicators work? Can you please outline steps needed to prevent problems. Should the @PriorDayOHLC/@CurrentDayOHL indicators be deleted? And should every place where "'GetSessionDate" has to be replaced by GetTradingDayFromLocal ? Any other methods related to session that have to be replaced from beta 21 onwards?


Thanks
mmtrader

[NinjaTrader_Josh]

mmtrader,

System indicators are always handled by the installer so you don't have to worry about messing with @PriorDayOHLC or @CurrentDayOHL. Custom indicators though, there is no way around it but those will simply need to be modified by either you or the original author. There current versions simply may not work until they have been modified to accomodate the necessary changes that were made.

[mmtrader]

Thanks Josh for clarifying. Is there any possibility that beta 22 be the production release? or there could be a beta 23 in next few weeks?

Thanks
mmtrader