NinjaTrader Support Forum  
X

Attention!

This website will be down for maintenance from Friday May 24th at 6PM MDT until Sunday May 26th at 12PM MDT. We apologize for the inconvenience. If you need assistance during this time, please email sales@ninjatrader.com


Go Back   NinjaTrader Support Forum > NinjaScript Development Support > Strategy Development

Strategy Development Support for the development of custom automated trading strategies using NinjaScript.

Reply
 
Thread Tools Display Modes
Old 12-14-2008, 02:39 PM   #1
junkone
Senior Member
 
Join Date: Sep 2008
Posts: 356
Thanks: 1
Thanked 1 time in 1 post
Default first successful strategy coded

hello
i have successfully coded my first strategy. it basically trades a price breakout or price breakdown (iput the cross over price) and sets trailing stop using ATR.
if someone could take a quick look to see if i did right or wrong. i would apprecite it.
my next task is to automate the entry price and triling stop using a form.
Attached Files
File Type: zip ZLRTrader.zip (4.9 KB, 79 views)
junkone is offline  
Reply With Quote
Old 12-14-2008, 03:46 PM   #2
NinjaTrader_Ray
Administrator
 
NinjaTrader_Ray's Avatar
 
Join Date: Nov 2004
Location: Denver, CO, USA
Posts: 11,163
Thanks: 6
Thanked 45 times in 32 posts
Default

Great, hopefully someone will chime in however...

- Does it work as you expect?
- If yes, then don't sweat your code sincem there are always ways to improve things
NinjaTrader_Ray is offline  
Reply With Quote
Old 12-14-2008, 04:06 PM   #3
junkone
Senior Member
 
Join Date: Sep 2008
Posts: 356
Thanks: 1
Thanked 1 time in 1 post
Default

it works for me as a long. hope someone can take a peek and code review it.
junkone is offline  
Reply With Quote
Old 12-15-2008, 06:02 AM   #4
NinjaTrader_Bertrand
NinjaTrader Customer Service
 
NinjaTrader_Bertrand's Avatar
 
Join Date: Sep 2008
Location: Germany
Posts: 22,421
Thanks: 252
Thanked 982 times in 964 posts
Default

Fine job, nicley commented out! Not sure what type of feedback you are looking for, as long as it works as expected for you - Great! If you notice some code becomes a burden on performance, you can always improve its efficiency.
NinjaTrader_Bertrand is offline  
Reply With Quote
Reply

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
Are all indicators published in TASC coded for Ninjatrader verge Indicator Development 9 03-06-2009 07:10 AM
Play sound on successful compilation Rollins Suggestions And Feedback 3 06-06-2008 02:53 PM
Volume Bars color-coded according to Price change Lost Trader Indicator Development 6 10-23-2007 11:15 PM
Sharing a successful Stategy edgeliner Strategy Development 2 10-19-2007 02:42 PM


All times are GMT -6. The time now is 08:49 PM.